install: Move /var mount test to TMT to reduce disk usage#1910
install: Move /var mount test to TMT to reduce disk usage#1910henrywang merged 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively reduces disk space usage for mount tests by switching to a 5GB sparse file in /var/tmp and adjusting partition layouts accordingly. This is a good improvement for CI efficiency. I've identified a high-severity issue related to the lifecycle management of the temporary disk image file, which could lead to test failures or unexpected behavior. Please review the specific comment for details and a suggested fix.
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Thanks for digging into this! Offhand looks sane, though I think we could probably handle this better by sharding some of these install tests in separate tmt tests too.
We're already growing overlap between test-install and tmt anyways.
ckyrouac
force-pushed
the
ci-disk-space
branch
from
0ddfb60 to
44f84fa
Compare
|
Hm still ran out of space 😭 |
|
going to move these tests to tmt |
ckyrouac
force-pushed
the
ci-disk-space
branch
from
44f84fa to
3dcaffa
Compare
ckyrouac
changed the title
ckyrouac
force-pushed
the
ci-disk-space
branch
from
3dcaffa to
1dc1ed3
Compare
The "install to-filesystem with separate /var mount" test was causing disk space issues on GitHub Actions runners due to its large disk image requirements (12GB for partitions with LVM). Moving it to a TMT test allows it to run in a dedicated VM where disk space is not as constrained. The test verifies that bootc install to-filesystem correctly handles scenarios where /var is on a separate filesystem, which is a common production setup. Changes: - Remove the test from Rust integration tests (install.rs) - Add new TMT test: test-32-install-to-filesystem-var-mount.sh - Add package requirements (parted, lvm2, dosfstools, e2fsprogs) - Update tests.fmf and integration.fmf with new test entry Assisted-by: Claude Code (Opus 4.5) Signed-off-by: ckyrouac <ckyrouac@redhat.com>
ckyrouac
force-pushed
the
ci-disk-space
branch
from
1dc1ed3 to
1713d48
Compare
4 participants
The "install to-filesystem with separate /var mount" test was causing
disk space issues on GitHub Actions runners due to its large disk
image requirements (12GB for partitions with LVM). Moving it to a TMT
test allows it to run in a dedicated VM where disk space is not as
constrained.
The test verifies that bootc install to-filesystem correctly handles
scenarios where /var is on a separate filesystem, which is a common
production setup.
Changes:
Assisted-by: Claude Code (Opus 4.5)
Signed-off-by: ckyrouac ckyrouac@redhat.com