tmt: Change var name to be less confusing#1999
Merged
Johan-Liebert1 merged 1 commit intobootc-dev:mainfrom Feb 12, 2026
Merged
Conversation
We had `works_for_composefs` as a field of the struct to signify whether a test works for composefs or not. We then changed the actual yaml counterpart to be `fixme_skip_if_composefs` but the var name remained as is which is a bit confusing. Also, remove some debug code in tests Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves code clarity by renaming the works_for_composefs variable to skip_if_composefs, which now correctly reflects its purpose of indicating whether a test should be skipped for the composefs backend. The associated comments have also been updated for better understanding. Additionally, a debug line has been removed from a test script. The changes are correct and improve the maintainability of the code. I have not found any issues with this pull request.
jeckersb
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had
works_for_composefsas a field of the struct to signify whether a test works for composefs or not. We then changed the actual yaml counterpart to befixme_skip_if_composefsbut the var name remained as is which is a bit confusing.Also, remove some debug code in tests