test: Add tests for missing /boot and --bootloader=none#2029
Merged
cgwalters merged 2 commits intobootc-dev:mainfrom Mar 3, 2026
Merged
test: Add tests for missing /boot and --bootloader=none#2029cgwalters merged 2 commits intobootc-dev:mainfrom
cgwalters merged 2 commits intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds two new integration tests for bootc. The first test verifies that bootc install to-filesystem works correctly when the target filesystem does not have a /boot directory. The second test checks that bootc install with the --bootloader=none option completes successfully. The changes are well-structured and follow the existing patterns for tests in this repository. I've found a minor issue in one of the new test scripts where an unused directory is created, and I've suggested its removal.
henrywang
force-pushed
the
new-test
branch
6 times, most recently
from
b3ebfe8 to
72f72b1
Compare
cgwalters
requested changes
Mar 2, 2026
Add two new integration tests: - test-35-install-no-boot-dir: Tests install to-filesystem when /boot directory is absent - test-36-install-bootloader-none: Tests install with --bootloader=none option to skip bootloader management Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Replace the complex get_target_image function with a simpler approach: use `bootc image copy-to-storage` to copy the booted image to local container storage, then reference it as containers-storage:localhost/bootc. Also add a run_install helper in tap.nu to eliminate copy-pasted systemd-run boilerplate across install tests. Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
cgwalters
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new integration tests: