-
-
Notifications
You must be signed in to change notification settings - Fork 193
ci: allow runners to use mold, increased concurrency to 4 #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
can we bump up the concurrency on gh runners to 4 then instead of 3? do we see any improvement? |
That was done in the recent push :) Seems that we barely get an improvement across the board. A couple of runners are faster and a couple of them aren't any different. |
|
I mean mold will only affect linking which is a fraction of the time the runners spend on D++ |
|
@braindigitalis Ignore my last comment about "little results". CodeQL is now ~3 minutes faster (comparing https://github.com/brainboxdotcc/DPP/actions/runs/9921615282/job/27409774387?pr=1197 with https://github.com/brainboxdotcc/DPP/actions/runs/9921876515/job/27410330135?pr=1198). The Action Runners now builds on average 30 seconds to 2 minutes faster (seems like Clang15, g++13, g++14, and g++15, were nearly 2 minutes faster now). Self hosted runner arm7hf didn't benefit at all, same with self hosted runner arm64. OSX didn't have any change to concurrency, nor linker. Neither did Windows. |
true true, the reason it's dropped a good bit is the concurrency being upped to 4. |
|
CodeQL is now down another minute! We're seeing 17 mins now! |
This PR attempts to speed up the action runners by allowing them to use mold and also changing the concurrency to 3 instead of 2 (github action runners were updated to 4 cores a while ago).
The checklist does not apply here.