Skip to content

Conversation

@Jaskowicz1
Copy link
Contributor

This PR attempts to speed up the action runners by allowing them to use mold and also changing the concurrency to 3 instead of 2 (github action runners were updated to 4 cores a while ago).

The checklist does not apply here.

@netlify
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 4fa6cb8
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6692e4fdfff7c500088ac581
😎 Deploy Preview https://deploy-preview-1198--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jul 13, 2024
@braindigitalis
Copy link
Contributor

can we bump up the concurrency on gh runners to 4 then instead of 3? do we see any improvement?

@Jaskowicz1
Copy link
Contributor Author

can we bump up the concurrency on gh runners to 4 then instead of 3? do we see any improvement?

That was done in the recent push :)

Seems that we barely get an improvement across the board. A couple of runners are faster and a couple of them aren't any different.

@Jaskowicz1 Jaskowicz1 changed the title ci: allow runners to use mold, increased concurrency to 3 ci: allow runners to use mold, increased concurrency to 4 Jul 13, 2024
@Mishura4
Copy link
Member

I mean mold will only affect linking which is a fraction of the time the runners spend on D++
mold really shines when LTO is enabled

@Jaskowicz1
Copy link
Contributor Author

Jaskowicz1 commented Jul 13, 2024

@braindigitalis Ignore my last comment about "little results".

CodeQL is now ~3 minutes faster (comparing https://github.com/brainboxdotcc/DPP/actions/runs/9921615282/job/27409774387?pr=1197 with https://github.com/brainboxdotcc/DPP/actions/runs/9921876515/job/27410330135?pr=1198).

The Action Runners now builds on average 30 seconds to 2 minutes faster (seems like Clang15, g++13, g++14, and g++15, were nearly 2 minutes faster now).

Self hosted runner arm7hf didn't benefit at all, same with self hosted runner arm64.

OSX didn't have any change to concurrency, nor linker. Neither did Windows.

@Jaskowicz1
Copy link
Contributor Author

I mean mold will only affect linking which is a fraction of the time the runners spend on D++ mold really shines when LTO is enabled

true true, the reason it's dropped a good bit is the concurrency being upped to 4.

@Jaskowicz1
Copy link
Contributor Author

CodeQL is now down another minute! We're seeing 17 mins now!

@braindigitalis braindigitalis merged commit db03496 into dev Jul 16, 2024
@braindigitalis braindigitalis deleted the mold_action_runners branch July 16, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants