Skip to content

Conversation

@tuokri
Copy link
Contributor

@tuokri tuokri commented Jan 28, 2025

Fixes the following warning when compiling on MSVC:

dpp\include\dpp\coro/awaitable.h(686): warning C4245: 'argument': conversion from 'int' to 'const unsigned char', signed/unsigned mismatch

P.S. thanks to Discord user MacOS master.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 156a0c7
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67989b9bc25e070008092b1d
😎 Deploy Preview https://deploy-preview-1367--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jan 28, 2025
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@braindigitalis braindigitalis merged commit 51b8f62 into brainboxdotcc:dev Jan 28, 2025
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants