-
-
Notifications
You must be signed in to change notification settings - Fork 193
require c++17 #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require c++17 #1404
Conversation
clang 16 may bug out on macos if it is not explicitly provided
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mishura4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add it at the top directly after project IMO
it shouldnt be hard coded to C++17. Our default is C++20 now unless its not supported or DPP_NO_CORO is set. The value for the standard should reflect this setting. |
braindigitalis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to use the standard which is set by the detections not hard code to C++17, this could cause conflicts later down the line where the order of these definitions is assumed.
It's not, if you set it to 17 first and then to 20, it'll be 20 |
i moved the declaration to the top
clang 16 may bug out on macos if it is not explicitly provided
added a line to require c++17 before linking std::filesystem
Code change checklist