Skip to content

Conversation

@erics118
Copy link
Contributor

clang 16 may bug out on macos if it is not explicitly provided

added a line to require c++17 before linking std::filesystem

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

clang 16 may bug out on macos if it is not explicitly provided
@github-actions github-actions bot added the build Issue or Pull Request related to the build process label Mar 24, 2025
@netlify
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 30a5ea7
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67ea58d0199cea00087d4aa5
😎 Deploy Preview https://deploy-preview-1404--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add it at the top directly after project IMO

@braindigitalis
Copy link
Contributor

Just add it at the top directly after project IMO

it shouldnt be hard coded to C++17. Our default is C++20 now unless its not supported or DPP_NO_CORO is set. The value for the standard should reflect this setting.

Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to use the standard which is set by the detections not hard code to C++17, this could cause conflicts later down the line where the order of these definitions is assumed.

@Mishura4
Copy link
Member

Mishura4 commented Mar 24, 2025

Just add it at the top directly after project IMO

it shouldnt be hard coded to C++17. Our default is C++20 now unless its not supported or DPP_NO_CORO is set. The value for the standard should reflect this setting.

It's not, if you set it to 17 first and then to 20, it'll be 20

@braindigitalis braindigitalis dismissed Mishura4’s stale review April 6, 2025 20:43

i moved the declaration to the top

@braindigitalis braindigitalis merged commit 25fcc4f into brainboxdotcc:dev Apr 6, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issue or Pull Request related to the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants