Skip to content

Conversation

@ruslan-ilesik
Copy link
Contributor

[ Please outline your change here. Be sure to check the checkboxes below. ]

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • [?] I tested that my change works before raising the PR. (passes unit tests)
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Custom destructor is required as type for openssl_bignum is incomplete at compile time and my
g++ (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
on wsl2 refuses to compile it with error

In file included from /usr/include/c++/13/memory:78,
from /home/ilesik/DPP/library/../include/dpp/nlohmann/json_fwd.hpp:14,
from /home/ilesik/DPP/library/../include/dpp/json_fwd.h:25,
from /home/ilesik/DPP/library/../include/dpp/snowflake.h:24,
from /home/ilesik/DPP/library/../include/dpp/dpp.h:36,
from /home/ilesik/DPP/src/unittest/test.h:27,
from /home/ilesik/DPP/src/unittest/test.cpp:22:
/usr/include/c++/13/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = dpp::openssl_bignum]’:
/usr/include/c++/13/bits/unique_ptr.h:404:17: required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = dpp::openssl_bignum; _Dp = std::default_deletedpp::openssl_bignum]’
/home/ilesik/DPP/library/../include/dpp/bignum.h:88:2: required from here
/usr/include/c++/13/bits/unique_ptr.h:97:23: error: invalid application of ‘sizeof’ to incomplete type ‘dpp::openssl_bignum’
97 | static_assert(sizeof(_Tp)>0,
| ^~~~~~~~~~~

  Given work around solves this issue.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 4494071
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/692645e21a0e370008d5ab1b
😎 Deploy Preview https://deploy-preview-1518--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Nov 26, 2025
@braindigitalis braindigitalis merged commit ae145d5 into brainboxdotcc:dev Nov 26, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants