Skip to content

Conversation

@Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Aug 18, 2023

collect_reactions never used "override" with virtual void completed(), this changes that. Whilst it's not needed, it's better to be explicit.

This also clears the random indentation on line 36 (prev. line 29).

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.
  • I agree to the terms of the DCO (Developer Certificate of Origin)

collect_reactions never used "override" with virtual void completed(), this changes that. Whilst it's not needed, it's better to be explicit.

This also clears a questionable indent on line 36.
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit a424d45
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64e09d69e7d63000077b1834
😎 Deploy Preview https://deploy-preview-780--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 marked this pull request as draft August 18, 2023 20:30
@Jaskowicz1
Copy link
Contributor Author

PR is marked as draft until #779 is complete so I can deal with the conflicts.

@Commandserver Commandserver added the documentation Improvements or additions to documentation label Aug 18, 2023
@Jaskowicz1
Copy link
Contributor Author

Jaskowicz1 commented Aug 19, 2023

It appears "Files Changed" now shows changes from #779.

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review August 19, 2023 09:45
@braindigitalis braindigitalis changed the base branch from master to dev August 19, 2023 10:03
@braindigitalis
Copy link
Contributor

needs to be merged to dev not master, I have updated this

@Jaskowicz1
Copy link
Contributor Author

needs to be merged to dev not master, I have updated this

Thought I had, sorry about that!!

@braindigitalis braindigitalis merged commit 818310a into brainboxdotcc:dev Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants