Use tarballs with nested folders for release archives#40
Merged
max-baz merged 4 commits intobrowserpass:masterfrom Apr 7, 2019
Merged
Use tarballs with nested folders for release archives#40max-baz merged 4 commits intobrowserpass:masterfrom
max-baz merged 4 commits intobrowserpass:masterfrom
Conversation
erayd
approved these changes
Apr 7, 2019
Collaborator
erayd
left a comment
erayd
left a comment
There was a problem hiding this comment.
Looks good - thank you for making this change :-).
Makefile
Outdated
| if [ "$$os" = "windows64" ]; then \ | ||
| (cd $(TMP) && zip -FSr ${CURDIR}/dist/browserpass-"$$os"-$(VERSION).zip browserpass-"$$os"-$(VERSION)); \ | ||
| else \ | ||
| (cd $(TMP) && tar -cvf ${CURDIR}/dist/browserpass-"$$os"-$(VERSION).tar.gz --use-compress-program=gzip browserpass-"$$os"-$(VERSION)); \ |
Collaborator
There was a problem hiding this comment.
I'm curious why --use-compress-program=gzip rather than simply using -z. It doesn't matter either way, and the result is identical, but the choice of syntax is unusual.
Member
Author
There was a problem hiding this comment.
I don't usually use tar directly so I simply didn't know about -z flag, I use a helper script from prezto, so I took the command from their sources - and their command looks like --use-compress-program=pigz because they use parallel compression 🙂
But for this Makefile will simplify, since archives are small and I wasn't planning to use parallel compression here anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39