Minor documentation updates to docs/WASI-tutorial.md#6839
Merged
pchickey merged 2 commits intobytecodealliance:mainfrom Aug 14, 2023
Merged
Minor documentation updates to docs/WASI-tutorial.md#6839pchickey merged 2 commits intobytecodealliance:mainfrom
pchickey merged 2 commits intobytecodealliance:mainfrom
Conversation
The `cat /tmp/somewhere.txt` command in the example using --dir=$PWD is not needed. The error message should be after the first command anyway since it should be the one creating the message. It looks like a copy/paste error since the previous example showed the same `cat` command a successful copy.
The error messages appear to have changed since this document was originally written.
github-actions
bot
added
the
wasmtime:docs
pchickey
approved these changes
Aug 14, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Aug 18, 2023
…e#6839) * Docs: Remove unneeded command in WASI-tutorial.md The `cat /tmp/somewhere.txt` command in the example using --dir=$PWD is not needed. The error message should be after the first command anyway since it should be the one creating the message. It looks like a copy/paste error since the previous example showed the same `cat` command a successful copy. * Docs: Update error messages in WASI-tutorial.md. The error messages appear to have changed since this document was originally written.
geekbeast
pushed a commit
to geekbeast/wasmtime
that referenced
this pull request
Aug 18, 2023
…time into feature/wasi-nn-preview-2 * 'feature/wasi-nn-preview-2' of github.com:geekbeast/wasmtime: Memcheck for Wasm guests in Wasmtime (bytecodealliance#6820) CI: upgrade to qemu 8.0.4. (bytecodealliance#6849) Sync wasi-cli with wit definitions in standards repo (bytecodealliance#6806) Rename `preview2::preview2` to `preview2::host` (bytecodealliance#6847) winch: Simplify the MacroAssembler and Assembler interfaces (bytecodealliance#6841) There are no files in `preview1` other than `mod.rs` (bytecodealliance#6845) Update stdio on Unix to fall back to worker threads (bytecodealliance#6833) Update RELEASES.md (bytecodealliance#6838) Minor documentation updates to docs/WASI-tutorial.md (bytecodealliance#6839) Add support for vector in DataValueExt::int() (bytecodealliance#6844)
|
This user is malicious by the way, just wanted to let you all know :3 cc: @pchickey |
|
considering its a doc change I doubt this would have a backdoor in it :). We also don't know if it's was caused by a compromised account or was indeed malicious afaik. This is probably not the place to discuss that though |
Member
|
Yes, we're aware of the situation here, and, if anyone has new information to report, please follow the Bytecode Alliance security process and report it to security@bytecodealliance.org. |
Member
|
Blog post on bytecodealliance.org about this pull request: https://bytecodealliance.org/articles/xz-backdoor-and-wasmtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I was working through your tutorial in the beginning of my journey to port something to be able to run in wasi-sdk. This PR should fix a minor copy/paste error and update some of the error messages.
wasi-sdk version: 20.11gf3b43c703f1a (compiled/installed from source)
wasmtime-cli: 11.0.1
I hope this helps!