Avoid using --single-branch in tests#155
Merged
OpsBotPrime merged 4 commits intomasterfrom Aug 11, 2022
Merged
Conversation
... by making sure that the local repository is cloned at the right time. The --single-branch argument does a bit more than just ordering git to clone only the given branch, but actually changes the way the repository is tracked so that only the given (master) branch is tracked. This makes it so that tests behave differently from the actual running app, notably when dealing with parallel and speculative builds as in #77. This change makes it so that tests and running code are more similar.
marcin-rzeznicki
suggested changes
Aug 11, 2022
marcin-rzeznicki
left a comment
marcin-rzeznicki
left a comment
There was a problem hiding this comment.
I added a couple of questions. Some things weren't that clear to me. Other than that, I won't be standing in the way of progress 😄
Author
|
@marcin-rzeznicki Thanks for the review. I believe to have addressed your comments (with changes in the comments). Can you please review again? 😁 |
Author
|
@marcin-rzeznicki Awesome. Thanks again for the review. @OpsBotPrime merge |
|
Pull request approved for merge by @rudymatela, rebasing now. |
Approved-by: rudymatela Auto-deploy: false
|
Rebased as 4873ebe, waiting for CI … |
|
CI job started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using
--single-branchin tests by making sure that the local repository is cloned at the right time.The
--single-branchargument does a bit more than just ordering git to clone only the given branch, but actually changes the way the repository is tracked so that only the given (master) branch is tracked. This makes it so that tests behave differently from the actual running app, notably when dealing with parallel and speculative builds as in #77.This change makes it so that tests and running code are more similar.
This is needed for #137.