-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[wrangler] Add analytics properties to secret commands #11777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f23eb8d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @MattieTK's task —— View job Changeset Review✅ All changesets look good The changeset
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I wonder if we should/could use a helper to ensure that the secretOperation can only be single or bulk, to help avoid typos etc if adding new calls in the future?
@petebacondarwin Any reason you'd do this with a helper over a union type? In either case there's going to be nothing really stopping you from just passing a string to the properties object because we're not typing the whole thing (unless that is the suggestion?) |
The problem is that the So I don't think we get much value by doing this. |
|
Yeah I think both solutions (your less so) suffer from creating a pattern that only exists in this once instance. If we were typing every event then that would be different (and we possibly could do this, it may be valuable), but probably not worth this one off. |
Summary
wrangler secret put,wrangler secret bulk, and their Pages/versions equivalents to better understand how secrets are being managedsecretOperation(single/bulk),secretSource(interactive/stdin/file),secretFormat(json/dotenv for bulk), andhasEnvironment(boolean)