Merged
Conversation
⏱️ Benchmark resultsComparing with 47da73d
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
=======================================
Coverage 47.18% 47.18%
=======================================
Files 76 76
Lines 7841 7841
=======================================
Hits 3700 3700
Misses 3642 3642
Partials 499 499
☔ View full report in Codecov by Sentry. |
hermanschaaf
approved these changes
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
pbdirectory public as Im preparing for v3 and removing some code duplication that we had with versions around clients. Now old servers and clients will be able to just import an old version instead of copying all the old versions to the new SDK.