Skip to content

refactor: use all in one egg v4#855

Merged
fengmk2 merged 14 commits intomasterfrom
use-tegg-v4
Oct 28, 2025
Merged

refactor: use all in one egg v4#855
fengmk2 merged 14 commits intomasterfrom
use-tegg-v4

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Oct 23, 2025

required eggjs/egg#5654

@graphite-app
Copy link

graphite-app bot commented Oct 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • MQ - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

58 files out of 165 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use-tegg-v4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fengmk2 fengmk2 requested a review from Copilot October 27, 2025 16:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates cnpmcore from multiple separate @eggjs/tegg-* packages to a unified Egg.js v4 framework where all tegg functionality is bundled within the main egg package. This consolidation simplifies dependency management and aligns with the new Egg.js v4 architecture.

Key changes:

  • Consolidated all @eggjs/tegg-* packages into the single egg package
  • Updated import paths from @eggjs/tegg/* to egg and egg/* subpaths
  • Standardized decorator and type imports across the codebase
  • Updated plugin configuration to use the new tracer plugin format

Reviewed Changes

Copilot reviewed 155 out of 156 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Removed 9 separate @eggjs/tegg-* dependencies, added @oxc-node/core dev dependency
config/plugin.ts Replaced manual tegg plugin declarations with tracerPlugin() function import
app/repository/model/*.ts Updated Model and Attribute imports from @eggjs/tegg/orm to egg/orm
app/repository/*.ts Updated decorator imports (Inject, SingletonProto, AccessLevel) from @eggjs/tegg to egg
app/repository/util/*.ts Updated EggProtoImplClass and metadata utility imports to egg
app/port/controller/*.ts Replaced @context decorator with @HttpContext, updated type imports from @eggjs/tegg to egg
app/port/schedule/*.ts Updated schedule decorators and types from @eggjs/tegg/schedule to egg/schedule
app/port/middleware/*.ts Updated middleware types from @eggjs/tegg to egg
app/core/service/*.ts Updated service decorators and AOP imports from @eggjs/tegg to egg
app/core/event/*.ts Updated event decorators from @eggjs/tegg to egg
app/common/adapter/*.ts Updated adapter imports and HTTP client types to egg
app/port/typebox.ts Changed Type.RegEx to Type.RegExp
app/infra/*.ts Updated infrastructure adapter imports to egg
INTEGRATE.md Updated documentation examples to use egg imports
.github/copilot-instructions.md Updated example code to use consolidated egg imports

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 99.55257% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.21%. Comparing base (e8a3ee5) to head (08397d7).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
app/port/controller/BinarySyncController.ts 85.71% 1 Missing ⚠️
.../port/controller/admin/PaddingVersionController.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   95.35%   95.21%   -0.15%     
==========================================
  Files         197      197              
  Lines       23853    23855       +2     
  Branches     1964     2305     +341     
==========================================
- Hits        22746    22713      -33     
- Misses       1107     1142      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2 fengmk2 marked this pull request as ready for review October 28, 2025 13:58
@fengmk2 fengmk2 requested a review from Copilot October 28, 2025 14:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 163 out of 164 changed files in this pull request and generated 1 comment.

@fengmk2
Copy link
Member Author

fengmk2 commented Oct 28, 2025

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MK (fengmk2) <fengmk2@gmail.com>
fengmk2 and others added 2 commits October 28, 2025 22:09
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MK (fengmk2) <fengmk2@gmail.com>
@fengmk2 fengmk2 merged commit 89f1250 into master Oct 28, 2025
26 of 27 checks passed
@fengmk2 fengmk2 deleted the use-tegg-v4 branch October 28, 2025 14:17
fengmk2 pushed a commit that referenced this pull request Nov 18, 2025
[skip ci]

## 4.12.0 (2025-11-18)

* feat: add builds/driver for playwright (#884) ([93034bf](93034bf)), closes [#884](#884) [#883](#883)
* feat: add ffmpeg-builds binary mirror (#879) ([d7de1cd](d7de1cd)), closes [#879](#879)
* feat: try to avoid recalculating integrity (#880) ([4859ce8](4859ce8)), closes [#880](#880)
* chore: add deployment test (#874) ([0d32146](0d32146)), closes [#874](#874)
* chore: Configure Renovate (#845) ([f3f3584](f3f3584)), closes [#845](#845)
* chore(deps): update actions/attest-build-provenance action to v3 (#847) ([957f43d](957f43d)), closes [#847](#847)
* chore(deps): update actions/checkout action to v5 (#849) ([e8a3ee5](e8a3ee5)), closes [#849](#849)
* chore(deps): update actions/first-interaction action to v3 (#850) ([35a7be3](35a7be3)), closes [#850](#850)
* chore(deps): update actions/setup-node action to v6 (#851) ([3671c52](3671c52)), closes [#851](#851)
* chore(deps): update dependency lint-staged to v16 (#853) ([e1848c7](e1848c7)), closes [#853](#853)
* chore(deps): update dependency mocha to v11.7.4 (#846) ([4213bd8](4213bd8)), closes [#846](#846)
* chore(deps): update dependency oxlint-tsgolint to ^0.3.0 (#863) ([0c987a7](0c987a7)), closes [#863](#863)
* chore(deps): update dependency oxlint-tsgolint to ^0.5.0 (#875) ([95543b1](95543b1)), closes [#875](#875)
* chore(deps): update dependency oxlint-tsgolint to ^0.7.0 (#885) ([06a3ae1](06a3ae1)), closes [#885](#885)
* chore(deps): update dependency type-fest to v5 [skip ci] (#871) ([01385f4](01385f4)), closes [#871](#871)
* fix(deps): update dependency npm-package-arg to v13 (#866) ([c3059c7](c3059c7)), closes [#866](#866)
* fix(deps): update dependency read-env-value to v2 (#869) ([098c75a](098c75a)), closes [#869](#869)
* fix(deps): update dependency ssri to v13 (#870) ([0f11e77](0f11e77)), closes [#870](#870)
* fix(deps): update dependency validate-npm-package-name to v7 [skip ci] (#873) ([6c29f08](6c29f08)), closes [#873](#873)
* refactor: use all in one egg v4 (#855) ([89f1250](89f1250)), closes [#855](#855)
@github-actions
Copy link

🎉 This PR is included in version 4.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant