Conversation
Based on jifei's PHP class available at: https://github.com/jifei/Pinyin/blob/master/Pinyin.php
Edited customRulesProvider()
|
I believe that you only need to run "bin/generate-default.php" for your PR to pass the unit tests. Thank you for adding chinese.. |
Updated default rules by running bin/generate-default.php
| ['romanian', 'ă î â ş ș ţ ț Ă Î Â Ş Ș Ţ Ț', 'a-i-a-s-s-t-t-a-i-a-s-s-t-t'], | ||
| ['serbian', 'А Б В Г Д Ђ Е Ж З И Ј К Л Љ М Н Њ О П Р С Т Ћ У Ф Х Ц Ч Џ Ш а б в г д ђ е ж з и ј к л љ м н њ о п р с т ћ у ф х ц ч џ ш Š Đ Ž Ć Č š đ ž ć č', 'a-b-v-g-d-dj-e-z-z-i-j-k-l-lj-m-n-nj-o-p-r-s-t-c-u-f-h-c-c-dz-s-a-b-v-g-d-dj-e-z-z-i-j-k-l-lj-m-n-nj-o-p-r-s-t-c-u-f-h-c-c-dz-s-s-dj-z-c-c-s-dj-z-c-c'], | ||
| ['lithuanian', 'Ą Č Ę Ė Į Š Ų Ū Ž ą č ę ė į š ų ū ž', 'a-c-e-e-i-s-u-u-z-a-c-e-e-i-s-u-u-z'], | ||
| ['chinese', '活动日起', 'huodongriqi'], |
There was a problem hiding this comment.
Hi, I don't know but maybe this is more readable? -> "Huo-Dong-Ri-Qi"
There was a problem hiding this comment.
From my understanding of Pinyin, I don't think you can do that.
|
Any progress on this? This is necessary for Chinese support. |
|
Hi, I'm a Chinese user and looking for Chinese slug support, I discover there will be a problem if you use Pinyin to transfer slug, for example, "中" : "zhong",
"忠" : "zhong",
"终" : "zhong",
"盅" : "zhong",
"钟" : "zhong",
"衷" : "zhong",
"肿" : "zhong",
"冢" : "zhong",
"踵" : "zhong",
"仲" : "zhong",
"众" : "zhong",they all spell |
|
@elleyyu thanks for your feedback! This commit is based on jifei's PHP class, you should probably report any issue there, if any. ;) Pinyin is purely a representation of the sounds of Mandarin, it completely lacks the semantic cues and contexts inherent in Chinese characters (see this). @hifall I replied to your comment earlier, don't know why my message was removed. Basically I was saying I didn't know why tests were not successful, all I can say is it works (see here). Unless someone can help, this pull request will remain open. Sorry. |
|
Fixed by #195 |
6 participants
No description provided.