Added Chinese support (Pinyin)#195
Merged
florianeckerstorfer merged 1 commit intococur:masterfrom Nov 30, 2017
franmomu:master
Merged
Added Chinese support (Pinyin)#195florianeckerstorfer merged 1 commit intococur:masterfrom franmomu:master
florianeckerstorfer merged 1 commit intococur:masterfrom
franmomu:master
Conversation
Based on jifei's PHP class available at: https://github.com/jifei/Pinyin/blob/master/Pinyin.php
Member
|
Since you basically copied the lost from the mentioned script I have to ask what is the license of that code? Or is this list publicly available? |
Contributor
Author
|
It is in the commit's message: a3a2f5d: (Not sure if it is what you meant) |
Member
|
What I meant was what is the license of the project? Are we allowed to use the code from this other project here? |
Contributor
Author
Member
|
Thanks, ping me if you've got a response. |
Contributor
Author
|
@florianeckerstorfer I've just got a response:
So, is it enough with the commit comment? or should I add the repository url somewhere else? (I can only think of the |
Member
|
@franmomu I will add a note to the README. Thanks for the PR. |
Contributor
Author
|
You're welcome! |
This was referenced Nov 30, 2017
Closed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just cloned #158, rebased and squash the commits