Use multibyte-safe case convertion#78
Merged
florianeckerstorfer merged 1 commit intococur:masterfrom Oct 2, 2015
Merged
Conversation
florianeckerstorfer
pushed a commit
that referenced
this pull request
Oct 2, 2015
Use multibyte-safe case convertion
Member
|
Did you encounter any problems because |
Contributor
Author
|
It doesn't works correctly for russian slugs that used utf-8 |
Member
|
Ok, because the Russian characters are not transliterated? |
Contributor
Author
|
As you see from transliteration rules we should duplicate rules for capital and small letters 'Щ' => 'Shch',
'щ' => 'shch',It is ok, but when we add rules for 2 charachters, like <call method="addRule">
<argument>ый</argument>
<argument>yi</argument>
</call>
<call method="addRule">
<argument>дж</argument>
<argument>j</argument>
</call>it is so hard, because we should add rules for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.