This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Fix crash with tuple concatenation onto list#615
Merged
thomasrockhu-codecov merged 2 commits intocodecov:mainfrom Feb 6, 2025
Merged
Fix crash with tuple concatenation onto list#615thomasrockhu-codecov merged 2 commits intocodecov:mainfrom
thomasrockhu-codecov merged 2 commits intocodecov:mainfrom
Conversation
thomasrockhu-codecov
previously approved these changes
Feb 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
- Coverage 94.69% 94.68% -0.01%
==========================================
Files 88 85 -3
Lines 3222 3219 -3
==========================================
- Hits 3051 3048 -3
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thomasrockhu-codecov
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I was trying to exclude files from my upload with
codecovcli -v upload-coverage -d --exclude testsand I got the following error:On further inspection, I'm guessing that click is producing a tuple instead of a list when creating the contents of the exclude argument. If you want this fix to be implemented further up the call chain, feel free to just close this PR, but I figured if this works then it took about 5 seconds to fix so I implemented it this way. This already has the error checking for if
folders_to_ignoreisNoneand I'm just casting the tuple to a list.