refactor: fix static analysis errors#423
Merged
kenjis merged 2 commits intocodeigniter4:developfrom Sep 7, 2022
Merged
Conversation
kenjis
changed the title
kenjis
commented
Sep 7, 2022
| ]); | ||
| } | ||
|
|
||
| assert($token->last_used_at instanceof Time || $token->last_used_at === null); |
Member
Author
There was a problem hiding this comment.
I don't know why but without this line, phpstan reports errors.
Member
There was a problem hiding this comment.
How about adding @property Time|null $last_used_at to the entity?
Oh, you already did! Yeah I'm not sure either.
Collaborator
There was a problem hiding this comment.
Although I don't like doing anything without understanding the reason, #417 seems to be waiting for this PR.
MGatner
approved these changes
Sep 7, 2022
datamweb
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.