Conversation
Co-authored-by: ArtOfCode <ArtOfCode-@users.noreply.github.com>
Contributor
Author
|
@ArtOfCode- With the changes in this PR,
Or perhaps you have other suggestions? |
Member
|
@Taeir I'd increase the limit. 200 is probably a number mostly out of thin air - in this case it's not enough, so let's make it more. |
Closed
ArtOfCode-
approved these changes
Jan 30, 2023
Member
ArtOfCode-
left a comment
ArtOfCode-
left a comment
There was a problem hiding this comment.
LGTM, approving, not merging right now because of deploy sequencing.
Member
|
@ArtOfCode- is the "deploy sequencing" concern still an issue? |
This was referenced May 5, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All credit for this feature goes to @MoshiKoi
I have only addressed some of the PR comments and fixed some minor issues as indicated in the original PR #890.
Since I am not able to add changes directly to someone else's branch/fork of the repo, I had to create a new branch and PR.