Fix mappers for keys not in memento #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now mappers for keys not in the memento are not being output if the mapper is defined in the model. They are only output if the mapper is passed as an argument to the getMementoFunction. Right now the getMementoFunction is skipping keys that don't match to arguments.mappers. It should be skipping keys that don't match to thisMemento.mappers which is the combination of arguments.mappers and mappers defined in the model's this.memento.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now mappers for keys not in the memento are not being output if the mapper is defined in the model. They are only output if the mapper is passed as an argument to the getMementoFunction. The getMementoFunction is skipping keys that don't match to arguments.mappers. It should be skipping keys that don't match to thisMemento.mappers which is the combination of arguments.mappers and mappers defined in the model's this.memento.