Full screen UI improvements #2493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const [lastSessionId, setLastSessionId] = useState<string | undefined>(); | ||
|
|
||
| useEffect(() => { | ||
| const storedId = localStorage.getItem("lastSessionId"); |
Collaborator
There was a problem hiding this comment.
We have a file with typings for all of our localStorage accessors: https://github.com/continuedev/continue/blob/main/gui/src/util/localStorage.ts
So I think we should add this there and update to use the getLocalStorage fn.
Contributor
Author
There was a problem hiding this comment.
This code actually wasn't needed. Removed it 👌
| // Note that these breakpoints are primarily optimized for the input toolbar | ||
| screens: { | ||
| xxs: "170px", // Smallest width for Primary Sidebar in VS Code | ||
| "2xs": "170px", // Smallest width for Primary Sidebar in VS Code |
Collaborator
There was a problem hiding this comment.
Thanks for making this update! 😁
TyDunn
requested changes
Oct 8, 2024
Contributor
TyDunn
left a comment
TyDunn
left a comment
There was a problem hiding this comment.
@tomasz-stefaniak Looks like a good next iteration! My two thoughts:
- I suspect we'll want to increase the breakpoint a little, so that the history section is only added if the sidebar is expanded a bit wider than the current breakpoint
- I think we should work on making the history page look / feel much nicer after we get this merged
Contributor
Author
|
sestinj
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added history sidebar on large screens.
Checklist
dev, rather thanmainScreenshots
Screen.Recording.2024-10-08.at.5.50.00.PM.mov
Testing
[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change. ]