Updates glab from 1.22.0 to 1.24.1; fixes #2 #3
Merged
corbob merged 8 commits intocorbob:masterfrom Dec 7, 2022
Merged
Conversation
Update downloaded filenames and sha256 hashes
Update version in glab.portable.nuspec
Update version in glab.nuspec
Update text, version, filenames and sha256 hashes in VERIFICATION.txt
Fix version typo in glab.nuspec (1.24.10 -> 1.24.1)
Migrate `chocolateyinstall.ps1` from deprecated `-file` and `-file64` to `-url` and `-url64bit` parameters and from embedded ZIP files (that were already gone) to downloads from the [v1.24.1 release URL](https://gitlab.com/gitlab-org/cli/-/releases/v1.24.1)
As the package is no longer embedding zip files, the verification file is no longer needed.
corbob
approved these changes
Dec 7, 2022
Owner
corbob
left a comment
corbob
left a comment
There was a problem hiding this comment.
Overall this looks good to me @jpluimers, thanks for getting this put together.
There are a few changes I'd like to add that are not actually from parts you've changed. I've added the suggestions to this PR, and will commit them as well.
Along with removing the Verification.txt file as it's no longer necessary since the files aren't being embedded in the package anymore.
Owner
|
Thanks a lot for getting this updated @jpluimers. I've packed it and pushed it up to the Community Repository: https://community.chocolatey.org/packages/glab/1.24.1 and https://community.chocolatey.org/packages/glab.portable/1.24.1 |
|
curious about namings - gitlab-cli vs glab - intended? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates GitLab CLI (glab) from 1.22.0 to 1.24.1; fixes #2