Merged
Conversation
Contributor
Author
|
Due to nightly not compiling it looks like we have a chicken/egg issue with the lint-ing. I am going to update this pr to include the change from this, and deal with the fallout from the merge of this change later. coreos/repo-templates#230 |
prestist
force-pushed
the
update-MSRV
branch
2 times, most recently
from
f988fdc to
1d5863f
Compare
tormath1
approved these changes
Jun 17, 2024
README.md
Outdated
|
|
||
| [](https://crates.io/crates/afterburn) | ||
|  | ||
|  |
Contributor
There was a problem hiding this comment.
Suggested change
|  | |
|  |
Contributor
Author
There was a problem hiding this comment.
Ah good catch! Thank you
Additionally run `cargo update` to update all dep's.
I have made a MR into repo-templates to update this file. seen here: coreos/repo-templates#230 Once it lands the downstream MR for updating the toolchain will not be able to merge due to failing CI we currently have, and we cannot merge the fix for the failing CI without it. So add the lint CI update here to allow CI fixes to be mergable.
First: update default_features to default-features in cargo.toml Second: replace get(0) with first()
Apprently we have had deadcode which is now being picked up by latest MSRV lint. Created issue to evaluate it coreos#1085.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally run
cargo updateto update all dep's.