Fix loongarch64 GOARCH value#1942
Merged
prestist merged 2 commits intocoreos:mainfrom Sep 16, 2024
k0tran:patch-1
Merged
Conversation
uname gives loongarch64 target value while go has loong64 target instead. Without the fix `make install` can't find correct executable since it looks into bin/loongarch64 instead of bin/loong64
Contributor
Author
|
Changed commit message to suit contribution formatting |
prestist
reviewed
Sep 16, 2024
| GOARCH=amd64 | ||
| else ifeq ($(GOARCH),aarch64) | ||
| GOARCH=arm64 | ||
| else ifeq ($(GOARCH),loongarch64) |
Collaborator
There was a problem hiding this comment.
We might want to add an item for release notes? if not I can skip them but I think it could be useful to communicate this.
Contributor
Author
There was a problem hiding this comment.
Made additional commit with only short description.
In changelog provided broad description and left link to this PR for details
Collaborator
|
Thank you for submitting this, just one small question otherwise lgtm. |
prestist
approved these changes
Sep 16, 2024
Collaborator
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So in loongarch64
uname -mgivesloongarch64but Go hasloong64target instead. This PR proposes changes to set GOARCH toloong64ifloongarch64encountered.