Destroyed/finishing activity check on hide#137
Merged
crazycodeboy merged 3 commits intocrazycodeboy:masterfrom Jul 10, 2018
flatfox-ag:destroyed_check
Merged
Destroyed/finishing activity check on hide#137crazycodeboy merged 3 commits intocrazycodeboy:masterfrom flatfox-ag:destroyed_check
crazycodeboy merged 3 commits intocrazycodeboy:masterfrom
flatfox-ag:destroyed_check
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we are getting crashes that dismiss was called on finishing or destroyed activity.
This PR adds check for it before dismissing the splash screen dialog.
I couldn't find for sure that
isFinishing()must returntruewhenisDestroyed()istrueso I've addedisDestroyed()check too for API >= 17.