Fix: Renamed sceneItem.id prop to avoid Duplicate Preset Effect List issues#2920
Merged
ebiggz merged 7 commits intocrowbartools:v5from Dec 9, 2024
Merged
Conversation
Oceanity
changed the title
sceneItem.id prop to avoid Duplicate Preset Effect List issues
ebiggz
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
If a user has copied a Preset Effect List containing the Trasform OBS Source effect, the effect's
sceneItem.idprop would be changed to a Guid due to Firebot's behavior on Duplicating. Before it would silently fail but the effect will now show an error message at the top:If the
idprop still exists and is correct, saving changes to the effect will automatically convert it to the newitemIdprop, and to avoid breaking the effect for folks that don't update,idwill still be passed if notnullwhen the effect is run.Testing
Tested that legacy instances of Transform OBS Source and new instances created after are still working after this change, and instances that are in an error state show the error message