Fix: setting the highest required cpp standard version#3277
Merged
dyzheng merged 4 commits intodeepmodeling:developfrom Dec 19, 2023
Merged
Fix: setting the highest required cpp standard version#3277dyzheng merged 4 commits intodeepmodeling:developfrom
dyzheng merged 4 commits intodeepmodeling:developfrom
Conversation
njzjz
added a commit
to njzjz/abacus-feedstock
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Member
|
Maybe apply 9c472e9 in this PR? |
Member
Author
OK, will do |
dyzheng
approved these changes
Dec 19, 2023
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Jul 13, 2024
Copy from deepmodeling/abacus-develop#3277 Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
to deepmodeling/deepmd-kit
that referenced
this pull request
Jul 13, 2024
Copied from deepmodeling/abacus-develop#3277 authored by @caic99 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced compatibility with different Torch versions by dynamically setting the appropriate C++ standard (C++14 or C++17) based on the Torch version. - **Improvements** - Improved build process with automatic detection and configuration of Torch version dependencies. - Enhanced robustness with additional checks and conditional logic for Torch integration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to deepmodeling/deepmd-kit
that referenced
this pull request
Jul 13, 2024
Copied from deepmodeling/abacus-develop#3277 authored by @caic99 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced compatibility with different Torch versions by dynamically setting the appropriate C++ standard (C++14 or C++17) based on the Torch version. - **Improvements** - Improved build process with automatic detection and configuration of Torch version dependencies. - Enhanced robustness with additional checks and conditional logic for Torch integration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to deepmodeling/deepmd-kit
that referenced
this pull request
Jul 13, 2024
Copied from deepmodeling/abacus-develop#3277 authored by @caic99 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced compatibility with different Torch versions by dynamically setting the appropriate C++ standard (C++14 or C++17) based on the Torch version. - **Improvements** - Improved build process with automatic detection and configuration of Torch version dependencies. - Enhanced robustness with additional checks and conditional logic for Torch integration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this pull request
Sep 18, 2024
…deling#3973) Copied from deepmodeling/abacus-develop#3277 authored by @caic99 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced compatibility with different Torch versions by dynamically setting the appropriate C++ standard (C++14 or C++17) based on the Torch version. - **Improvements** - Improved build process with automatic detection and configuration of Torch version dependencies. - Enhanced robustness with additional checks and conditional logic for Torch integration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
conda-forge/abacus-feedstock#12
What's changed?
Any changes of core modules? (ignore if not applicable)