Chore: refactor InvarFitting#3266
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3266 +/- ##
=======================================
Coverage 74.98% 74.99%
=======================================
Files 384 384
Lines 33522 33547 +25
Branches 1604 1604
=======================================
+ Hits 25136 25157 +21
- Misses 7525 7529 +4
Partials 861 861 ☔ View full report in Codecov by Sentry. |
|
@wanghan-iapcm, this is only a draft, not tested, but it's what i have in mind. feels like we can reuse a large portion of the code from InvarFitting, we only need to change the output dim from |
|
please note that the predictions of dipole and polar are rotationally equivariant. |
I thought this handles the rotational equivariance, deepmd-kit/deepmd/pt/model/task/dipole.py Line 203 in 9bc9900 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Anyang Peng <137014849+anyangml@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@wanghan-iapcm UT 'test_make_hessian_model` fails on CUDA, not sure if it was tested before. |
for more information, see https://pre-commit.ci
No description provided.