Skip to content

Comments

breaking: change DeepTensor output dim from nsel_atoms to natoms#3390

Merged
njzjz merged 2 commits intodeepmodeling:develfrom
njzjz:change-deeptensor-output
Mar 2, 2024
Merged

breaking: change DeepTensor output dim from nsel_atoms to natoms#3390
njzjz merged 2 commits intodeepmodeling:develfrom
njzjz:change-deeptensor-output

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Mar 2, 2024

No description provided.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested review from iProzd and wanghan-iapcm March 2, 2024 09:28
@github-actions github-actions bot added the Python label Mar 2, 2024
@njzjz njzjz added the breaking change Breaking changes that should notify users. label Mar 2, 2024
@codecov
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (c61ba88) to head (e3756ce).
Report is 3 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3390      +/-   ##
==========================================
- Coverage   76.58%   76.57%   -0.01%     
==========================================
  Files         420      420              
  Lines       35705    35721      +16     
  Branches     1620     1620              
==========================================
+ Hits        27345    27355      +10     
- Misses       7492     7498       +6     
  Partials      868      868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz added this pull request to the merge queue Mar 2, 2024
Merged via the queue into deepmodeling:devel with commit 59d3b12 Mar 2, 2024
@njzjz njzjz deleted the change-deeptensor-output branch March 2, 2024 17:44
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaking changes that should notify users. Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants