chore(tests): ensure the same result of frame 0 and 1#4442
chore(tests): ensure the same result of frame 0 and 1#4442njzjz merged 4 commits intodeepmodeling:develfrom
Conversation
Copied from deepmodeling/deepmd-gnn#27. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request focus on the Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
source/tests/universal/common/cases/model/utils.py (1)
186-193: Consider enhancing error handling in frame comparisonWhile the frame consistency check is well-implemented, consider adding more detailed error information when assertions fail.
if ret[0][kk] is not None: np.testing.assert_allclose( ret[0][kk][0], ret[0][kk][1], - err_msg=f"compare {kk} between frame 0 and 1", + err_msg=f"Frame mismatch for {kk}: absolute diff = {np.abs(ret[0][kk][0] - ret[0][kk][1]).max()}, relative diff = {np.abs((ret[0][kk][0] - ret[0][kk][1]) / (ret[0][kk][0] + 1e-10)).max()}", )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/tests/universal/common/cases/model/utils.py(2 hunks)
🔇 Additional comments (2)
source/tests/universal/common/cases/model/utils.py (2)
122-122: LGTM: Frame count increase aligns with PR objective
The change from nf = 1 to nf = 2 enables testing frame consistency, which is the main goal of this PR.
130-133: LGTM: Array initialization properly handles multiple frames
The array initialization changes correctly:
- Use
repeatto duplicate frame data consistently - Maintain proper shapes for multiple frames
- Ensure identical data across frames for testing consistency
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4442 +/- ##
==========================================
+ Coverage 83.72% 83.74% +0.02%
==========================================
Files 667 667
Lines 61446 61533 +87
Branches 3486 3486
==========================================
+ Hits 51443 51532 +89
+ Misses 8877 8873 -4
- Partials 1126 1128 +2 ☔ View full report in Codecov by Sentry. |
2 participants
Copied from deepmodeling/deepmd-gnn#27.
Summary by CodeRabbit
Bug Fixes
Tests