fix(jax): fix repflows JIT issues#4775
Merged
iProzd merged 1 commit intodeepmodeling:develfrom May 30, 2025
Merged
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR addresses JIT incompatibility in repflows by guarding the Python int() conversion behind a dynamic selection flag.
- Guard
int()call withself.use_dynamic_selto avoid JIT errors when static. - Default
n_edgeto0when dynamic selection is disabled.
Comments suppressed due to low confidence (1)
deepmd/dpmodel/descriptor/repflows.py:1329
- Using Python int(...) inside JIT can break tracing. To maintain JIT compatibility and consistent array types, prefer using
.item()on the xp scalar. For example:
n_edge = xp.sum(xp.astype(nlist_mask, xp.int32)).item() if self.use_dynamic_sel else xp.array(0, dtype=xp.int32)n_edge = (int(xp.sum(xp.astype(nlist_mask, xp.int32))) if self.use_dynamic_sel else 0)
Contributor
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RepFlowLayer
User->>RepFlowLayer: call(...)
alt use_dynamic_sel is True
RepFlowLayer->>RepFlowLayer: n_edge = int(nlist_mask.sum())
else use_dynamic_sel is False
RepFlowLayer->>RepFlowLayer: n_edge = 0
end
RepFlowLayer-->>User: result
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (29)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #4775 +/- ##
=======================================
Coverage 84.79% 84.79%
=======================================
Files 698 698
Lines 67746 67746
Branches 3540 3540
=======================================
+ Hits 57444 57445 +1
Misses 9171 9171
+ Partials 1131 1130 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iProzd
approved these changes
May 30, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit