Implemented recipe files for dub #2684#2685
Merged
WebFreak001 merged 11 commits intodlang:masterfrom Aug 13, 2023
Merged
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 14 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5272064 bin/dub
-rough build time=78s
+executable size=5280256 bin/dub
+rough build time=77sFull build output |
Contributor
Author
Contributor
Author
|
I found a bug: The cache when using the --recipe is the same as not using, I need to make the recipe name enter in the ending file, do you guys have any direction on where I need to modify? -- In the tests folder I also shows how to test it: I basically done what other people would implement using |
WebFreak001
requested changes
Aug 11, 2023
Member
WebFreak001
left a comment
WebFreak001
left a comment
There was a problem hiding this comment.
the test should actually check if the custom recipe file was used, look at the .sh files in the test folder as examples how you can script the testing framework
WebFreak001
requested changes
Aug 11, 2023
Member
|
you need to if you are on windows you can do this by doing |
Co-authored-by: Jan Jurzitza <gh@webfreak.org>
WebFreak001
requested changes
Aug 12, 2023
Member
WebFreak001
left a comment
WebFreak001
left a comment
There was a problem hiding this comment.
last thing, otherwise LGTM
WebFreak001
reviewed
Aug 12, 2023
WebFreak001
approved these changes
Aug 13, 2023
Member
|
the CI test fail seems related: |
WebFreak001
reviewed
Aug 13, 2023
Co-authored-by: Jan Jurzitza <gh@webfreak.org>
Member
|
EDIT: will do myself |
Member
|
after toying around, I noticed it silently ignores when the recipe file doesn't exist, will add a check for this |
Member
|
Why was this merged ? I don't see a compelling argument for it. It breaks in all kind of ways and clearly does not fit within Dub's philosophy - this is not to say that it isn't impossible to implement, but it breaks one of the major assumption without reason. |
Contributor
Author
|
Fix dub then.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been working on a new dub build system for my project and this PR is quite important to get merged ASAP (before LDC 1.34.0 is released) since it will make my game engine usable for the release process.
Right now my
This fixes a problem where I was using
sourcePathsinstead ofdependenciesfor releasing a game, the result being a big problem as the game could not contain any dependency unknown to the engine. By having that, it fixes this problem right now and make it a lot more usable.