Allow to load dub.selections.json before Project instantiation#2754
Merged
dlang-bot merged 1 commit intodlang:masterfrom Dec 26, 2023
Merged
Allow to load dub.selections.json before Project instantiation#2754dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 14 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5314384 bin/dub
-rough build time=66s
+rough build time=64sFull build output |
The aim of this commit is to have at least one constructor for Project that does not perform IO. By moving the IO to the `Dub` class, we can keep the dependency injection in `Dub` and `PackageManager` only, and don't have to specialize `Project`.
03c979c to
2bb3258
Compare
thewilsonator
approved these changes
Dec 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this commit is to have at least one constructor for Project that does not perform IO. By moving the IO to the
Dubclass, we can keep the dependency injection inDubandPackageManageronly, and don't have to specializeProject.