Skip to content

Update path module to vibe-core@2.8.5#2821

Merged
thewilsonator merged 3 commits intodlang:masterfrom
Geod24:upgrade-path
Apr 16, 2025
Merged

Update path module to vibe-core@2.8.5#2821
thewilsonator merged 3 commits intodlang:masterfrom
Geod24:upgrade-path

Conversation

@Geod24
Copy link
Member

@Geod24 Geod24 commented Jan 19, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
-executable size=5063520 bin/dub
+executable size=5051680 bin/dub
 rough build time=59s
Full build output 
DUB version 1.39.0, built on Mar 20 2025
LDC - the LLVM D compiler (1.40.1):
  based on DMD v2.110.0 and LLVM 19.1.7
  built with LDC - the LLVM D compiler (1.40.1)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
    xtensa      - Xtensa 32
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.40.1/x64/ldc2-1.40.1-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.39.0-rc.1+commit.44.g31fcc545: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5051680 bin/dub
STAT:rough build time=59s

@Geod24 Geod24 mentioned this pull request Jan 19, 2024
Merged
@Geod24 Geod24 force-pushed the upgrade-path branch 2 times, most recently from 21620c6 to 5659959 Compare March 8, 2024 16:15
@Geod24 Geod24 mentioned this pull request Jun 18, 2024
Closed
@Geod24 Geod24 changed the title Update path module to vibe-core@2.7.3 Update path module to vibe-core@2.8.5 Jun 25, 2024
@Geod24 Geod24 force-pushed the upgrade-path branch 2 times, most recently from 7cd408a to 26558a8 Compare September 25, 2024 01:32
@Geod24
Copy link
Member Author

Geod24 commented Sep 25, 2024 

16 deprecation warnings omitted, use `-verrors=0` to show all
     Linking dub-test-library
 : fatal error LNK1318: Unexpected PDB error; OK (0) ''

Error: linker exited with status 1318
       C:\Program Files (x[86](https://github.com/dlang/dub/actions/runs/11024681696/job/30618263676?pr=2821#step:7:87))\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\link.exe /NOLOGO "C:\Users\runneradmin\AppData\Local\dub\cache\dub\~master\build\dub-test-library-unittest-bHzpISJ3I5gwpabjIG5Npw\dub-test-library.obj" /OUT:"C:\Users\runneradmin\AppData\Local\dub\cache\dub\~master\build\dub-test-library-unittest-bHzpISJ3I5gwpabjIG5Npw\dub-test-library.exe"  /DEFAULTLIB:phobos64 /DEBUG  /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x64" legacy_stdio_definitions.lib /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\Lib\10.0.22621.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\um\x64"
Error dmd failed with exit code 1.

That looks like fun.

@Geod24
Copy link
Member Author

Geod24 commented Sep 25, 2024

Ubuntu: 228/234 tests were successed. (nice typo)

[INFO] Running /home/runner/work/dub/dub/test/ddox.sh...
    Starting Performing "ddox" build using dmd for x86_64.
    Building ddox-project ~master [library]
             ddox is not present, getting and storing it user wide
    Fetching ddox 0.16.23
     Warning Sub package vibe-d:utils, referenced by vibe-d:web dub.package_.Package must be referenced using the path to its base package
Error Dependency from vibe-d:web to vibe-d:utils uses wrong path: /home/runner/.dub/packages/vibe-d/0.10.0/vibe-d/web/../ vs. /home/runner/.dub/packages/vibe-d/0.10.0/vibe-d/
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:11 command failed
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:11 command failed
[ERROR] Script failure.

[INFO] Running /home/runner/work/dub/dub/test/4-describe-data-2-dmd.sh...
     Warning 
     Warning ## Warning for package describe-project ##
     Warning 
     Warning The following compiler flags have been specified in the package description
     Warning file. They are handled by DUB and direct use in packages is discouraged.
     Warning Alternatively, you can set the DFLAGS environment variable to pass custom flags
     Warning to the compiler, or use one of the suggestions below:
     Warning 
     Warning releaseMode: Call DUB with --build=release
     Warning debugInfo: Call DUB with --build=debug
     Warning 
Not expecting escaped paths
1c1
< /home/runner/work/dub/dub/test/describe-project/src/dummy.d --some-dflag --another-dflag -L--some-lflag -L--another-lflag -L-lsomelib -L-lanotherlib /home/runner/work/dub/dub/test/describe-dependency-3/libdescribe-dependency-3.a /home/runner/work/dub/dub/test/describe-project/some.a /home/runner/work/dub/dub/test/describe-dependency-1/dep.a /home/runner/work/dub/dub/test/describe-project/src/dummy.d /home/runner/work/dub/dub/test/describe-dependency-1/source/dummy.d -version=someVerIdent -version=anotherVerIdent -version=Have_describe_dependency_3 -debug=someDebugVerIdent -debug=anotherDebugVerIdent -I/home/runner/work/dub/dub/test/describe-project/src/ -I/home/runner/work/dub/dub/test/describe-dependency-1/source/ -I/home/runner/work/dub/dub/test/describe-dependency-2/some-path/ -I/home/runner/work/dub/dub/test/describe-dependency-3/dep3-source/ -J/home/runner/work/dub/dub/test/describe-project/views/ -J/home/runner/work/dub/dub/test/describe-dependency-2/some-extra-string-import-path/ -J/home/runner/work/dub/dub/test/describe-dependency-3/dep3-string-import-path/ /home/runner/work/dub/dub/test/describe-dependency-2/some-path/dummy.d -debug -g -gx -wi
---
> /home/runner/work/dub/dub/test/describe-project/src/dummy.d --some-dflag --another-dflag -L--some-lflag -L--another-lflag -L-lsomelib -L-lanotherlib /home/runner/work/dub/dub/test/describe-dependency-3/libdescribe-dependency-3.a /home/runner/work/dub/dub/test/describe-project/some.a /home/runner/work/dub/dub/test/describe-dependency-1/dep.a /home/runner/work/dub/dub/test/describe-project/src/dummy.d /home/runner/work/dub/dub/test/describe-project/../describe-dependency-1/source/dummy.d -version=someVerIdent -version=anotherVerIdent -version=Have_describe_dependency_3 -debug=someDebugVerIdent -debug=anotherDebugVerIdent -I/home/runner/work/dub/dub/test/describe-project/src/ -I/home/runner/work/dub/dub/test/describe-project/../describe-dependency-1/source/ -I/home/runner/work/dub/dub/test/describe-project/../describe-dependency-2/some-path/ -I/home/runner/work/dub/dub/test/describe-project/../describe-dependency-3/dep3-source/ -J/home/runner/work/dub/dub/test/describe-project/views/ -J/home/runner/work/dub/dub/test/describe-project/../describe-dependency-2/some-extra-string-import-path/ -J/home/runner/work/dub/dub/test/describe-project/../describe-dependency-3/dep3-string-import-path/ /home/runner/work/dub/dub/test/describe-dependency-2/some-path/dummy.d -debug -g -gx -wi
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:86 The project data did not match the expected output!
[ERROR] Script failure.

==> Missing normalization

[INFO] Running /home/runner/work/dub/dub/test/issue103-single-file-package.sh...
    Starting Performing "debug" build using dmd for x86_64.
    Building single-file-test ~master: building configuration [application]
     Linking single-file-test
     Running single-file-test 
Hello, World!
Error: module `hello` from file issue103-single-file-package.d conflicts with another module hello from file ./issue103-single-file-package.d
Error dmd failed with exit code 1.
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:12 command failed

[INFO] Running /home/runner/work/dub/dub/test/issue2840-build-collision.sh...
~/work/dub/dub/test/issue2840-build-collision ~/work/dub/dub
'build.d' -> 'nested/build.d'
Error: module `build` from file build.d conflicts with another module build from file ./build.d
Error dmd failed with exit code 1.
Error:  /opt/hostedtoolcache/dc/dmd-2.109.1/x64/dmd2/linux/bin64/dub:9 command failed
[ERROR] Script failure.
[INFO] Running /home/runner/work/dub/dub/test/issue877-auto-fetch-package-on-run.sh...
+ /home/runner/work/dub/dub/bin/dub remove 'gitcompatibledubpackage@*'
    Removing gitcompatibledubpackage (in /home/runner/.dub/packages/gitcompatibledubpackage/1.0.2/gitcompatibledubpackage/)
     Removed gitcompatibledubpackage 1.0.2
+ echo y
+ /home/runner/work/dub/dub/bin/dub run gitcompatibledubpackage
+ grep 'Hello DUB'
Error: module `hello` from file ../../../.dub/packages/gitcompatibledubpackage/1.0.4/gitcompatibledubpackage/hello.d conflicts with another module hello from file ../../../.dub/packages/gitcompatibledubpackage/1.0.4/gitcompatibledubpackage/./hello.d
Error dmd failed with exit code 1.
[ERROR] Script failure.

At a glance, they all look related to normalization.

@Geod24 Geod24 force-pushed the upgrade-path branch 5 times, most recently from 4bb5012 to 84c06c5 Compare January 2, 2025 09:16
@Geod24
Copy link
Member Author

Geod24 commented Jan 2, 2025

Only one test left failing:

[INFO] Running /Users/runner/work/dub/dub/test/issue103-single-file-package.sh...
    Starting Performing "debug" build using dmd for x86_64.
    Building single-file-test ~master: building configuration [application]
     Linking single-file-test
     Running single-file-test 
Hello, World!
Hello, World!
Hello, World!
Hello, World!
sourcelib.app.entry
0
Invocation triggered unnecessary rebuild.
[ERROR] Script failure.

As well as some seemingly-unrelated vibe-core issue which vibe-d/vibe-core#421 might solve

@Geod24
Copy link
Member Author

Geod24 commented Jan 2, 2025

And now triggering a compiler bug on Windows, this is really a gift that keeps on giving.
image

@thewilsonator
Copy link
Contributor

thewilsonator commented Jan 2, 2025

Needs more jpeg. I Can't read that at all.

@Geod24
Copy link
Member Author

Geod24 commented Jan 2, 2025 

Linking dub-test-library
 : fatal error LNK1318: Unexpected PDB error; OK (0) ''

Error: linker exited with status 1318
       C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX[64](https://github.com/dlang/dub/actions/runs/12582664320/job/35068724464?pr=2821#step:7:65)\x64\link.exe /NOLOGO "C:\Users\runneradmin\AppData\Local\dub\cache\dub\~master\build\dub-test-library-unittest-cPvxr5R3nUqncHBLjdHgDw\dub-test-library.obj" /OUT:"C:\Users\runneradmin\AppData\Local\dub\cache\dub\~master\build\dub-test-library-unittest-cPvxr5R3nUqncHBLjdHgDw\dub-test-library.exe"  /DEFAULTLIB:phobos64 /DEBUG  /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x64" legacy_stdio_definitions.lib /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\Lib\10.0.22621.0\ucrt\x64" /LIBPATH:"C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\um\x64"

@Geod24 Geod24 force-pushed the upgrade-path branch 8 times, most recently from 526b559 to 15a86fd Compare January 6, 2025 08:57
@Geod24
Copy link
Member Author

Geod24 commented Jan 6, 2025

Running into a few issues here. Having the ability to differentiate Posix path from Windows path is great and all, but we need to provide a consistent serialization format for selection files. At the same time, we do want to accept Windows-only input.

@Geod24 Geod24 force-pushed the upgrade-path branch 3 times, most recently from a20e052 to 33407aa Compare April 15, 2025 22:37
Geod24 added 2 commits April 16, 2025 00:59
@Geod24
feat(fs): Implement chdir to change the working directory
6a69392 
Currently our working directory is always the root,
which means that we didn't care about absolute vs relative path.
@Geod24
fix(mockfs): Improve Windows support and add tests
8215da7 
On Windows, the root has a name, which is the drive,
unlike on POSIX where the root is an empty name.
This led to a flurry of problems because we assumed
a POSIX style, where the FS is a directed graph,
while on Windows it is multiple unconnected graphs
(the drives cannot be accessed via a relative path).
@Geod24 Geod24 force-pushed the upgrade-path branch 3 times, most recently from 3614094 to 911c500 Compare April 16, 2025 00:54
@Geod24
Copy link
Member Author

Geod24 commented Apr 16, 2025

Another one: vibe-d/vibe-inet#11

@Geod24 Geod24 force-pushed the upgrade-path branch 2 times, most recently from cd33956 to 81d7280 Compare April 16, 2025 01:55
@Geod24
Copy link
Member Author

Geod24 commented Apr 16, 2025

We're down to 1 oddly failing test on Windows, which I can't reproduce locally.

@Geod24
Update path module to vibe-core@2.8.5 & url module to v1.1.1+
c9f1537 
The URL module actually includes a fix for an issue found while testing Dub.
@Geod24
Copy link
Member Author

Geod24 commented Apr 16, 2025

@thewilsonator Would you mind approving ?

@thewilsonator thewilsonator merged commit 102a8c1 into dlang:master Apr 16, 2025
32 checks passed
@Geod24 Geod24 deleted the upgrade-path branch April 16, 2025 03:32
@Geod24 Geod24 mentioned this pull request May 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Geod24 @thewilsonator

Comments