Move writing selections file to PackageManager#2864
Merged
Geod24 merged 1 commit intodlang:masterfrom Feb 17, 2024
Merged
Conversation
The PackageManager is the main source of IO in Dub, and having it take responsibility for writing the selections file reduces the number of special casing we need to make when doing dependency injection.
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5368480 bin/dub
+executable size=5372576 bin/dub
rough build time=66sFull build output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PackageManager is the main source of IO in Dub, and having it take responsibility for writing the
selections file reduces the number of special casing we need to make when doing dependency injection.