Enhancement of integration test for windows#2917
Merged
Geod24 merged 2 commits intodlang:masterfrom Jun 5, 2024
Merged
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5259464 bin/dub
-rough build time=65s
+rough build time=66sFull build output |
Member
|
Regarding the OMF change, we need to merge stable into master, there is a fix for it. |
Geod24
approved these changes
Jun 4, 2024
Member
Geod24
left a comment
Geod24
left a comment
There was a problem hiding this comment.
Thanks! Just rebase on master and address the comment and we're G2G.
test/run-unittest.d
Outdated
Comment on lines
17
to
19
| import std.path : absolutePath, buildPath, baseName, dirName, stripExtension, globMatch; | ||
| import std.process : environment, spawnProcess, spawnShell, wait, ProcessConfig = Config; | ||
| import std.string: cmp, splitLines; |
Member
There was a problem hiding this comment.
At this point I would just get rid of selective imports :)
test/run-unittest.d
Outdated
Comment on lines
111
to
117
| bool build; | ||
| if (!pack.name.buildPath(".no_build").exists | ||
| && !pack.name.buildPath(".no_build_" ~ dc_bin).exists | ||
| && !pack.name.buildPath(".no_build_" ~ os).exists) | ||
| { | ||
| //build=1 | ||
| build = true; |
Member
There was a problem hiding this comment.
Suggested change
| bool build; | |
| if (!pack.name.buildPath(".no_build").exists | |
| && !pack.name.buildPath(".no_build_" ~ dc_bin).exists | |
| && !pack.name.buildPath(".no_build_" ~ os).exists) | |
| { | |
| //build=1 | |
| build = true; | |
| bool build =(!pack.name.buildPath(".no_build").exists | |
| && !pack.name.buildPath(".no_build_" ~ dc_bin).exists | |
| && !pack.name.buildPath(".no_build_" ~ os).exists); | |
| if (build) | |
| { |
Slightly more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified
run-unittest.dto run integration tests for Windows.Also, since OMF was removed in the latest release (2.109.0), the OMF build test was removed.
With this PR, it is likely that
run-unittest.shwill become unnecessary, but it has been left in place. This is to ensure that all tests can still be executed as before. As a result, some tests are currently being run twice. If there are no issues after some time, it would be preferable to remove it.