Fix #2901: VersionRange.toString() doesn't handle >0.0.0#2926
Merged
Geod24 merged 1 commit intodlang:masterfrom Jun 11, 2024
Merged
Fix #2901: VersionRange.toString() doesn't handle >0.0.0#2926Geod24 merged 1 commit intodlang:masterfrom
Geod24 merged 1 commit intodlang:masterfrom
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5259464 bin/dub
rough build time=61sFull build output |
thewilsonator
approved these changes
Jun 11, 2024
The `VersionRange.toString` method was not ideal and dropping this rare case. A tiny improvement that was also done in the process is to give higher priority to `matchesAny` so that we get a more user-friendly output, given how common it is (e.g. for `ToolchainRequirement`).
s-ludwig
approved these changes
Jun 11, 2024
Member
Author
|
Interesting, this is broken. Because now serializing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VersionRange.toStringmethod was not ideal and dropping this rare case. A tiny improvement that was also done in the process is to give higher priority tomatchesAnyso that we get a more user-friendly output, given how common it is (e.g. forToolchainRequirement).