VersionRange: Always output minor version for ~> and ^#2928
Merged
s-ludwig merged 1 commit intodlang:masterfrom Jun 11, 2024
Merged
VersionRange: Always output minor version for ~> and ^#2928s-ludwig merged 1 commit intodlang:masterfrom
s-ludwig merged 1 commit intodlang:masterfrom
Conversation
Dub was correct in outputting only the major version, however this can lead to some confusion for users as pointed out in dlang#2830. Accepting ~>5 but only exposing two states (~>5.0 and ~>5.0.0) will hopefully make things a bit more obvious.
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5259464 bin/dub
-rough build time=62s
+rough build time=61sFull build output |
Member
|
I'd say the way you have it in the unit tests makes most sense. Following the general scheme, |
Member
Author
|
@s-ludwig : Anything else to do for now ? We probably want to deprecate it later but I don't think it's urgent. |
s-ludwig
approved these changes
Jun 11, 2024
Member
s-ludwig
left a comment
There was a problem hiding this comment.
Should be good to go for now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@s-ludwig : I was about to close #2830 as WONTFIX but thinking about it more reducing possible state is probably best. Thoughts ?