refactor: Move path-awareness for mkdir and lookup to Mockfs#2990
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jan 3, 2025
Merged
refactor: Move path-awareness for mkdir and lookup to Mockfs#2990dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
The goal of FSEntry is to be a node in a tree, and Filesystem implementations are the ones handling the complexity of dealing with NativePath. Using reduce with a seed we can greatly simplify those implementations, and reduce the risk of bugs.
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5334536 bin/dub
-rough build time=62s
+rough build time=61sFull build output |
thewilsonator
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of FSEntry is to be a node in a tree, and Filesystem implementations are the ones handling the complexity of dealing with NativePath. Using reduce with a seed we can greatly simplify those implementations, and reduce the risk of bugs.