Skip to content

Add copy button#57

Closed
blanchardjeremy wants to merge 3 commits intodmuth:mainfrom
blanchardjeremy:dev/add-copy-button
Closed

Add copy button#57
blanchardjeremy wants to merge 3 commits intodmuth:mainfrom
blanchardjeremy:dev/add-copy-button

Conversation

@blanchardjeremy
Copy link
Contributor

Mainly:

  • Adds copy button

Also:

  • Cleans up package.json scripts to not call npm install
  • Add cleaner way to prevent browser caching of webpack while in development
  • Move watch options into webpack

@dmuth
Copy link
Owner

dmuth commented Jan 31, 2025

This is all very good stuff, thanks for contributing it!

Because I have testing to do, I set up branch https://github.com/dmuth/diceware/tree/pr-57-test-branch with your commits in them, and a couple of things that I am tweaking related to that.

Once I finish testing, I'll deploy, merge that branch to main, and provide an update here.

Best,

-- Doug

@dmuth dmuth self-assigned this Jan 31, 2025
dmuth added a commit that referenced this pull request Feb 1, 2025
Merged changes from PR #57 along with some tweaks.
@dmuth dmuth mentioned this pull request Feb 1, 2025
@dmuth
Copy link
Owner

dmuth commented Feb 1, 2025

Okay, these changes were rolled in to #59. However, a new problem asserted itself, which I am working on in #60.

Thanks once again for the contribution, the copy button is a nice little feature for the app!

-- Doug

@dmuth dmuth closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments