bake: handle git auth token when parsing remote definition#288
Merged
crazy-max merged 1 commit intodocker:mainfrom Apr 12, 2024
Merged
bake: handle git auth token when parsing remote definition#288crazy-max merged 1 commit intodocker:mainfrom
crazy-max merged 1 commit intodocker:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
704f0f3 to
76b6d66
Compare
crazy-max
commented
Apr 5, 2024
92d3878 to
c5962d9
Compare
c5962d9 to
c1c961b
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
c1c961b to
329c1c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got the following output when trying to build from a remote bake definition on a private repo: https://github.com/docker/test-docker-action/tree/remote-private
Using a
GIT_AUTH_TOKENsecret doesn't seem to work:Which makes sense as loading remote bake definitions is done by a dedicated solve request, not during build: https://github.com/docker/buildx/blob/8abef5908705e49f7ba88ef8c957e1127b597a2a/bake/remote.go#L62
docker/buildx#2363 implements git auth token support for remote bake definitions using the
BUILDX_BAKE_GIT_AUTH_TOKENenv var.