inspect: display builder features#1854
Merged
jedevc merged 1 commit intodocker:masterfrom Jun 6, 2023
Merged
Conversation
jedevc
approved these changes
May 30, 2023
Collaborator
jedevc
left a comment
There was a problem hiding this comment.
LGTM for when we merge the history API detection 🎉
e7fe6ef to
35d7145
Compare
jedevc
approved these changes
May 30, 2023
Member
|
I guess this is fine although some of these were not designed to be user-visible but just the booleans that client code could use when handling flags. No way is this meant to be the same as BuildKit's cap-based feature detection for example. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
35d7145 to
6c9436f
Compare
Member
Author
|
Now displays features only if debug is enabled. |
jedevc
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #1846, I wanted to know nodes capability for some builders. I think we should display the list of features when inspecting a builder.