cli/command/registry: cleanup "search" and "login" tests#4488
Merged
thaJeztah merged 2 commits intodocker:masterfrom Aug 9, 2023
Merged
cli/command/registry: cleanup "search" and "login" tests#4488thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah merged 2 commits intodocker:masterfrom
Conversation
- TestSearchContext: don't use un-keyed structs - TestSearchContext: don't use CompareMultipleValues as it was not needed - TestSearchContextDescription: don't use un-keyed structs - TestSearchContextDescription: don't use CompareMultipleValues as it was not needed - TestSearchContextWrite: don't use un-keyed structs, and include the code-comments into the test-table as names for the tests to give them some context. - TestSearchContextWriteJSON and TestSearchContextWriteJSONField were not validating the output format, but validating if the JSON output could be marshalled back to a struct. Let's just role them into TestSearchContextWrite. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- use consts for fixed values, and rename some for clarity - remove testAuthErrors map and inline the logic (same as we do for other cases) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4488 +/- ##
=======================================
Coverage 59.39% 59.39%
=======================================
Files 288 288
Lines 24782 24782
=======================================
Hits 14720 14720
Misses 9175 9175
Partials 887 887 |
vvoland
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/command/registry: cleanup search tests
code-comments into the test-table as names for the tests to give them
some context.
validating the output format, but validating if the JSON output could
be marshalled back to a struct. Let's just role them into TestSearchContextWrite.
cli/command/registry: cleanup login tests
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)