docs/deprecated: Deprecate Container fields in image inspect

[vvoland]

See moby/moby#46939

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

Did we forget mentioning these as deprecated for the v25 release? Wondering if that means we need to wait for v27.0 to remove them, or did we document it in the API changes at the time?

[vvoland]

Yes, we forgot to put it there, but we mentioned it in version-history.md 🙈

The Container and ContainerConfig fields in the GET /images/{name}/json response are deprecated and will no longer be included in API v1.45.

But I'm fine with waiting for v27.0 for the removal, especially since the docker-py with the fixed tests is not released yet.

[thaJeztah]

Arf, I somehow missed your last comments. Some thoughts (maybe we don't have to postpone the removal);

• The API changes document is the "canonical" place for changes in the engine API, including deprecations
• I thought we always included a mention like "for changes and deprecations in the API refer to <link to API changes>"; if we don't, we should fix that.
• ☝️ perhaps we should also do a cross-reference in this deprecated page, to do the same ("for an overview of changes in API ...")

That said; I don't think it necessarily hurts to call out / repeat important changes here, but we may not have to for all of them.

@vvoland @dvdksn WDYT?

[thaJeztah]

FWIW; for some of these, it would at least make things easier as well, because the API is versioned so if you use the "older API version", nothing changes, but yeah, in some cases that may affect output of docker CLI commands.

docker inspect was meant to show the underlying "low-level" information, which would still be "accurate" here, but that underlying information now may no longer have these fields (or not set).

[dvdksn]

We link to both the deprecated.md and version-history.md from the release note:

I don't think it hurts to also cross-reference between these two.

If version-history.md is canonical then we should be safe to remove in 26.0 since this was called out (and linked from the release note). It just wasn't called out everywhere.

[vvoland]

Updated the removal notice to v26.

[codecov-commenter]

Codecov Report

Merging #4893 (02ee6b0) into master (f2e98f9) will increase coverage by 0.00%.
Report is 47 commits behind head on master.
The diff coverage is n/a.

❗ Current head 02ee6b0 differs from pull request most recent head 3b66d84. Consider uploading reports for the commit 3b66d84 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4893   +/-   ##
=======================================
  Coverage   61.31%   61.31%           
=======================================
  Files         287      287           
  Lines       20063    20065    +2     
=======================================
+ Hits        12301    12303    +2     
- Misses       6868     6869    +1     
+ Partials      894      893    -1     

[vvoland]

Changed deprecation candidate to v27

[dvdksn]

minor nits, nonblocking