Fix bash completion for events --filter daemon=#5554
Merged
thaJeztah merged 1 commit intodocker:masterfrom Oct 19, 2024
Merged
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5554 +/- ##
==========================================
- Coverage 60.67% 59.57% -1.10%
==========================================
Files 345 345
Lines 23491 29088 +5597
==========================================
+ Hits 14252 17330 +3078
- Misses 8266 10788 +2522
+ Partials 973 970 -3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed the "legacy" bash completion for
events --filter daemon=that no longer works.- How I did it
Changed completion logic from parsing the bare
docker infooutput to using a--filtermatching the desired values.- How to verify it
type
Before: no completion
With this fix: completion of ID and hostname of the current docker daemon.
- Description for the changelog
Fixed bash completion for
events --filter daemon=- A picture of a cute animal (not mandatory but encouraged)