opts: remove uses pkg/errors, and move swarm-specific opts to a separate package #5907
Merged
thaJeztah merged 3 commits intodocker:masterfrom Mar 10, 2025
Merged
opts: remove uses pkg/errors, and move swarm-specific opts to a separate package #5907thaJeztah merged 3 commits intodocker:masterfrom
thaJeztah merged 3 commits intodocker:masterfrom
Conversation
- remove uses of github.com/pkg/errors - slight improvement on handling parsing errors - add some test-cases Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5907 +/- ##
==========================================
+ Coverage 59.26% 59.31% +0.04%
==========================================
Files 357 357
Lines 29771 29782 +11
==========================================
+ Hits 17645 17666 +21
+ Misses 11153 11146 -7
+ Partials 973 970 -3 🚀 New features to boost your workflow:
|
This prevents users of the CLI that don't implement swarm-related features from depending on the swarm API types. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Benehiko
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opts: use stdlib errors and touch-up some errors
opts: move swarm-specific options to a separate package
This prevents users of the CLI that don't implement swarm-related
features from depending on the swarm API types.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)