system/info: failure to connect to docker socket should propagate error#5918
Merged
thaJeztah merged 1 commit intodocker:masterfrom Apr 10, 2025
Merged
system/info: failure to connect to docker socket should propagate error#5918thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5918 +/- ##
==========================================
- Coverage 59.33% 59.27% -0.07%
==========================================
Files 358 358
Lines 29783 29837 +54
==========================================
+ Hits 17672 17685 +13
- Misses 11142 11180 +38
- Partials 969 972 +3 🚀 New features to boost your workflow:
|
dcb5350 to
3c82131
Compare
thaJeztah
reviewed
Mar 10, 2025
56e6f6a to
7bec8d4
Compare
thaJeztah
reviewed
Mar 11, 2025
b69b09a to
c899a20
Compare
thaJeztah
reviewed
Mar 18, 2025
…uld propagate error This patch propagates the error up the stack when running `docker info` and a connection error to the server occurs. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
c899a20 to
353230d
Compare
Member
Author
|
@thaJeztah PTAL :) |
Member
|
Ah, sorry, I should've replied; I started reviewing, but ran into some other fun issues; will give this another look today 👍 |
thaJeztah
approved these changes
Apr 10, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
🙈 thought this one was already merged 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5900
- What I did
Propagate the failure to connect to the docker socket error up the stack.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)