context list: remove temporary ContextType from JSON output#5981
Merged
vvoland merged 1 commit intodocker:masterfrom Apr 11, 2025
Merged
context list: remove temporary ContextType from JSON output#5981vvoland merged 1 commit intodocker:masterfrom
vvoland merged 1 commit intodocker:masterfrom
Conversation
This reverts commit fed9fa0. This removes the ContextType field, which was temporarily added to provide compatibility with the "compose-cli" wrapper that shipped with Docker Desktop. The compose-cli wrapper extended the context struct with an additional field that was not part of the CLI itself, but was used by Visual Studio to detect the type of context. This temporary field shipped as part of Docker 27.0 June 2024), which should be enough time for Visual Studio to have adjusted their integration. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5981 +/- ##
==========================================
- Coverage 59.12% 59.11% -0.01%
==========================================
Files 355 355
Lines 29740 29716 -24
==========================================
- Hits 17583 17567 -16
+ Misses 11182 11174 -8
Partials 975 975 🚀 New features to boost your workflow:
|
Member
Author
|
Interesting failure; some issue with that test? Looks like potentially the context would be cancelled, which closes the pipe? cli/cli/command/container/run_test.go Lines 248 to 252 in 3349492 |
Member
Author
|
Flaky test; And weird error: "network prune cancelled has been cancelled"; I suspect the weird error message was accidental; cli/cli/command/network/prune.go Line 60 in 3349492 Looks like it was updated in 7c722c0 |
vvoland
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fed9fa0.
This removes the ContextType field, which was temporarily added to provide compatibility with the "compose-cli" wrapper that shipped with Docker Desktop. The compose-cli wrapper extended the context struct with an additional field that was not part of the CLI itself, but was used by Visual Studio to detect the type of context.
This temporary field shipped as part of Docker 27.0 June 2024), which should be enough time for Visual Studio to have adjusted their integration.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)