Use DOCKER_AUTH_CONFIG env as credential store#6008
Merged
vvoland merged 1 commit intodocker:masterfrom Jun 18, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6008 +/- ##
==========================================
+ Coverage 55.03% 55.56% +0.52%
==========================================
Files 361 356 -5
Lines 30153 29999 -154
==========================================
+ Hits 16596 16670 +74
+ Misses 12599 12366 -233
- Partials 958 963 +5 🚀 New features to boost your workflow:
|
866c70a to
eb43744
Compare
4 tasks
thaJeztah
reviewed
Apr 15, 2025
thaJeztah
reviewed
Apr 15, 2025
thaJeztah
reviewed
Apr 15, 2025
thaJeztah
reviewed
Apr 17, 2025
e7c6f4d to
b3aa07f
Compare
thaJeztah
reviewed
May 27, 2025
de90f77 to
b7770d7
Compare
thaJeztah
reviewed
May 27, 2025
d801989 to
0417f99
Compare
thaJeztah
reviewed
Jun 3, 2025
5e95a08 to
63c990c
Compare
thaJeztah
reviewed
Jun 6, 2025
Member
|
4978971 to
2d0b124
Compare
thaJeztah
reviewed
Jun 13, 2025
2d0b124 to
5f2a40a
Compare
thaJeztah
reviewed
Jun 17, 2025
vvoland
reviewed
Jun 17, 2025
Collaborator
vvoland
left a comment
There was a problem hiding this comment.
I noticed I had some pending comments
5f2a40a to
bb1bf8c
Compare
Member
|
@vvoland PTAL |
vvoland
reviewed
Jun 17, 2025
Collaborator
vvoland
left a comment
There was a problem hiding this comment.
Overall looks good, but left some comments
This patch enables the CLI to natively pick up the `DOCKER_AUTH_CONFIG`
environment variable and use it as a credential store.
The `DOCKER_AUTH_CONFIG` value should be a JSON object and must store
the credentials in a base64 encoded string under the `auth` key.
Specifying additional fields will cause the parser to fail.
For example:
`printf "username:pat" | openssl base64 -A`
`export DOCKER_AUTH_CONFIG='{
"auths": {
"https://index.docker.io/v1/": {
"auth": "aGk6KTpkY2tyX3BhdF9oZWxsbw=="
}
}
}'`
Credentials stored in `DOCKER_AUTH_CONFIG` would take precedence over any
credential stored in the file store (`~/.docker/config.json`) or native store
(credential helper).
Destructive actions, such as deleting a credential would result in a noop if
found in the environment credential. Credentials found in the file or
native store would get removed.
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
bb1bf8c to
9b83d5b
Compare
1 task
This was referenced Sep 29, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables the CLI to natively pick up the
DOCKER_AUTH_CONFIGenvironment variable and use it as a credential store.
The
DOCKER_AUTH_CONFIGvalue should be a JSON object and must storethe credentials in a base64 encoded string under the
authkey.Credentials stored in
DOCKER_AUTH_CONFIGwould take precedence over anycredential stored in the file store (
~/.docker/config.json) or native store(credential helper).
Destructive actions, such as deleting a credential would result in a noop if
found in the environment credential. Credentials found in the file or
native store would get removed.
- What I did
- How I did it
- How to verify it
printf "username:pat" | openssl base64 -ASetup the
DOCKER_AUTH_CONFIGenvironment variable- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)